[PMON] [Mellanox] fix syseepromd issue on simx #8131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@nazariig could you please help to review? |
nazariig
reviewed
Jul 13, 2021
nazariig
reviewed
Jul 13, 2021
nazariig
reviewed
Jul 14, 2021
| if not os.path.exists(os.path.dirname(EEPROM_SYMLINK)): | ||
| os.makedirs(os.path.dirname(EEPROM_SYMLINK)) | ||
| if not os.path.exists(EEPROM_SYMLINK): | ||
| subprocess.check_call(['/usr/bin/xxd', '-r', '-p', 'syseeprom.hex', EEPROM_SYMLINK], cwd=platform_path) |
There was a problem hiding this comment.
@tomer-israel why do we need to always check both?
Example:
if not os.path.exists(EEPROM_SYMLINK):
if not os.path.exists(os.path.dirname(EEPROM_SYMLINK)):
os.makedirs(os.path.dirname(EEPROM_SYMLINK))
subprocess.check_call(['/usr/bin/xxd', '-r', '-p', 'syseeprom.hex', EEPROM_SYMLINK], cwd=platform_path)There was a problem hiding this comment.
changed it as you suggested
nazariig
approved these changes
Jul 19, 2021
lguohan
approved these changes
Jul 19, 2021
|
This PR could not be cleanly cherry-pick to 202012. Please submit another PR. |
judyjoseph
added
Included in 202106 Branch
Request for 202106 Branch
and removed
Request for 202106 Branch
labels
judyjoseph
pushed a commit
that referenced
this pull request
Aug 4, 2021
Avoid initializing sfp/thermal/components/fan/psu/leds on simx and create vpd_info file on hw_management when we use mellanox simulator platform - Why I did it this is a fix for issue in mellanox simulator platforms. the syseepromd failed on the pmon docker. also "decode-syseeprom" failed also - How I did it before initializing thermal/components/fan/psu/leds --> check if we are running on simx creating the vpd_info on the hw_management folder. - How to verify it check if syseepromd process was loaded properly on the pmon docker. decode-syseeprom is working well without errors/warnings
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
Avoid initializing sfp/thermal/components/fan/psu/leds on simx and create vpd_info file on hw_management when we use mellanox simulator platform - Why I did it this is a fix for issue in mellanox simulator platforms. the syseepromd failed on the pmon docker. also "decode-syseeprom" failed also - How I did it before initializing thermal/components/fan/psu/leds --> check if we are running on simx creating the vpd_info on the hw_management folder. - How to verify it check if syseepromd process was loaded properly on the pmon docker. decode-syseeprom is working well without errors/warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid initializing sfp/thermal/components/fan/psu/leds on simx and create vpd_info file on hw_management when we use mellanox simulator platform
Why I did it
this is a fix for issue in mellanox simulator platforms. the syseepromd failed on the pmon docker. also "decode-syseeprom" failed also
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
fix issues on syseeprom on mellanox simulator platforms. problem was discovered on 202012 release.